Uploaded image for project: 'SW'
  1. SW-296

H2OConf remove nulls and make it more Scala-like

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.10, 2.1.3, 2.0.7
    • Component/s: None
    • Labels:
      None
    • CustomerVisible:
      No
    • Sprint:

      Description

      From: https://github.com/h2oai/sparkling-water/pull/87/files

      	
            @vpatryshev
      vpatryshev 25 days ago Member
      All these nulls... you should not use them in Scala. Same with 'asInstanceOf' - another case of bad Scala.
      
             @jakubhava
      jakubhava 25 days ago Member
      see comment above. Agreed, but it should be targeted to another commit since there are also cases like that in the previous sparkling water code
      
             @mmalohlava
      mmalohlava 24 days ago Member
      Please, another commit to change this one. Plus it is not critical problem right now.
      

        Attachments

          Activity

            People

            • Assignee:
              Kuba Jakub Hava
              Reporter:
              michal Michal Malohlava
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: